-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs/release: tag containers images with version #995
Conversation
haven't actually looked deeply at the code change, but one point to bring up: I think we need to make this behavior conditional? i.e. we don't want it to run in all of our pipelines do we? |
maybe we can work with @gursewak1997 on this over in the code he is working on coreos/coreos-assembler#3798 - we don't need to update the same PR, but maybe let's let that land and then we'll figure out the right way to slot in GC for quay? |
This should be configured via the pipecfg instead. See docs/config.yaml. |
This tag the manifest with the full version number. First step for coreos/fedora-coreos-tracker#1367
22bae57
to
078963c
Compare
@jlebon thanks for the review ! Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm not super familiar with some bits here so let's wait for at least Jonathan
My only concern with merging this right away is that as per coreos/fedora-coreos-tracker#1367 (comment), we have quite aggressive GC policies in mind for these tags. If we merge this but the GC side takes time to land, we'll have a tail of tags that will hang around and pollute our repo. I'm OK not blocking this on adding the GC side of it, but at least can we do this for production streams only for now? |
I looked a bit at it but this config file seems to apply to all the streams, so I am not sure to implement that. |
follow-up i am thinking about while working on the GC code for this: we should include the container images published to quay in the |
That should happen automatically. See https://github.com/coreos/coreos-assembler/blob/38235218542c39a29255933d3cea64e91754e85f/src/cmd-push-container-manifest#L128. |
Good, thanks for the confirmation. |
@jlebon i don't see knobs to adjust that per-stream in pipecfg. |
Re. the GC side of this, just cross-posting: coreos/coreos-assembler#3798 (comment) I'm thinking the GC script should live in either cosa or https://github.com/coreos/fedora-coreos-releng-automation/... kinda leaning towards the latter to make it easier to share with other projects in the future? (Similarly to fedora-ostree-pruner there). |
It's not documented (you're welcome to add it to fedora-coreos-pipeline/utils.groovy Line 460 in dc58259
It's a bit awkward because I think you'd need to redefine the whole
Definitely for working on the GC side, I would suggest using your own registry repo. |
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. If no duration is specified, no image will be pruned. See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. If no duration is specified, no image will be pruned. See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. If no duration is specified, no image will be pruned. See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in coreos#3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
This script calls skopeo delete to prune image from a remote directory. Currently only supports the FCOS tag structure. This consumes the same policy.yaml defined in #3798 See coreos/fedora-coreos-tracker#1367 See coreos/fedora-coreos-pipeline#995
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GC pieces are in cosa. We will wire it up shortly. Let's do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ouch, got here too late :) |
This tag the manifest with the full version number. First step for coreos/fedora-coreos-tracker#1367
Is it that simple ?
Obviously I need to add the GC code as well